Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in kettle_asset.xml to ensure compatibility with the latest MuJoCo versions. #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bugs in kettle_asset.xml to ensure compatibility with the latest MuJoCo versions. #238

wants to merge 1 commit into from

Conversation

Josh00-Lu
Copy link

@Josh00-Lu Josh00-Lu commented Oct 20, 2024 •
edited
Loading

Description

Explanation

There's a missing <default> tag in kettle_asset.xml. This will bring errors in the latest version of MuJoCo (>3.16). The problem is mentioned in: #236 (comment).

No dependencies are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Josh00-Lu Josh00-Lu changed the title Update kettle_asset.xml Fix bugs in kettle_asset.xml to ensure compatibility with the latest MuJoCo versions. Oct 20, 2024
@Josh00-Lu Josh00-Lu mentioned this pull request Oct 20, 2024
Open
@Kallinteris-Andreas
Copy link
Contributor

@Josh00-Lu can you make this PR in https://github.com/Farama-Foundation/Gymnasium-Robotics, and also validate that this change does not change the behavior of the environment for older versions of mujoco (3.1.6, 3.0.1, 2.3.7, 2.2.2, 2.1.5)

@Josh00-Lu
Copy link
Author

@Josh00-Lu can you make this PR in https://github.com/Farama-Foundation/Gymnasium-Robotics, and also validate that this change does not change the behavior of the environment for older versions of mujoco (3.1.6, 3.0.1, 2.3.7, 2.2.2, 2.1.5)

Sure.

@Josh00-Lu Josh00-Lu mentioned this pull request Nov 9, 2024
Open
11 tasks
@Josh00-Lu
Copy link
Author

Josh00-Lu commented Nov 9, 2024 •
edited
Loading

I have submit a PR in Farama-Foundation/Gymnasium-Robotics#255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh00-Lu @Kallinteris-Andreas